search

mvdan / gofumpt

A stricter gofmt
https://pkg.go.dev/mvdan.cc/gofumpt
BSD 3-Clause "New" or "Revised" License
3.15k stars 110 forks source link

Tracking issue: go release tag fails semver version check #280

Closed flowchartsman closed 6 months ago

flowchartsman commented 11 months ago

I created an issue that ended up as golang/go#61692, which involved RC version numbers failing gofumpt's semver check when attempting to determine minimal go version. This issue was resolved from the gopls side by massaging the version number before passing to gofumpt, and the issue was closed, however it was unclear from the discussion whether @mvdan would want to make doc or code modifications to gofumpt as a result, and I didn't find any followup from @findleyr on putative updates to x/mod so I thought I'd open this issue so the discussion didn't get lost.

Feel free to close if unnecessary!

mvdan commented 10 months ago

Thanks for filing this - indeed it's on my mind, and we should have a tracking issue here.

I've raised https://github.com/golang/go/issues/62039 to properly track the upstream feature request.

findleyr commented 10 months ago

Thanks both. Indeed, I hadn't gotten around to filing an issue, and appreciate your tracking this.