Adding a .pre-commit-hooks.yaml

mvdan / sh

A shell parser, formatter, and interpreter with bash support; includes shfmt

https://pkg.go.dev/mvdan.cc/sh/v3

BSD 3-Clause "New" or "Revised" License

7.2k stars 340 forks source link

Adding a .pre-commit-hooks.yaml #1010

Closed djgoku closed 1 year ago

djgoku commented 1 year ago

@scop is there a compelling reason not to move these pre-commit hooks into this repository?

mvdan commented 1 year ago

Thanks for your pull request. There have been quite a few of these, and I still don't understand the point of such a YAML file beyond stating "yes, you can run this with pre-commit". Anyone who wants to run shfmt can hopefully already do that with ease. See https://github.com/mvdan/sh/pull/966 for more details.

scop commented 1 year ago

Some related info over at #554, too. I understand the concerns, and I'm fine with maintaining the configs separately, and also here should the stance change sometime.

mvdan commented 1 year ago

Yeah, and I'm now reminded that upstream pre-commit shut down and locked our suggestions, so I'm not sure how to move forward. For now, my thinking hasn't changed :)