search

mvdan / sh

A shell parser, formatter, and interpreter with bash support; includes shfmt
https://pkg.go.dev/mvdan.cc/sh/v3
BSD 3-Clause "New" or "Revised" License
6.97k stars 332 forks source link

Update JS package to use go1.18.10 #1049

Closed esimkowitz closed 2 months ago

esimkowitz commented 6 months ago

I've updated the JS package to the latest version of gopherjs, which supports go1.18.10. I've tested that this builds and passes the tests.

I've updated the build script to prompt the user to install the Go SDK if it is not already present.

mvdan commented 6 months ago

Interesting timing, not sure if you saw my recent comment at https://github.com/mvdan/sh/issues/1018#issuecomment-1871582275.

Sure, I can try doing one more release with an outdated version of Go and a GopherJS beta release. It might work okay, or it might not. It would probably be the last release that I do with GopherJS, so I'd probably add a warning at the top of the npm package description to be clear about that.

I'll merge a simplified version of this given that now we can rely on GOTOOLCHAIN to run a precise version of Go without needing go install. I'll do that and try doing a release when I have better internet.