mvdan / sh

A shell parser, formatter, and interpreter with bash support; includes shfmt
https://pkg.go.dev/mvdan.cc/sh/v3
BSD 3-Clause "New" or "Revised" License
7.16k stars 338 forks source link

Prefix editorconfig properties #1094

Open sdavids opened 2 hours ago

sdavids commented 2 hours ago

You should prefix the .editorconfig properties defined by shfmt.

Similar to what JetBrains does:

Editorconfig

Generic IntelliJ options that have the ij_ prefix and are applicable to all languages

Otherwise different tools might interpret the same key—differently defeating the whole purpose of using .editorconfig in the first place.

mvdan commented 2 hours ago

Is this something that editorconfig themselves recommend? I don't oppose the idea, but I'd also prefer to stick to the upstream recommendations.

sdavids commented 1 hour ago

https://github.com/editorconfig/specification/issues/59

mvdan commented 1 hour ago

OK thanks. I will follow that thread for now.