interp: fix a PATH regression on Windows, fix tests on Wine

mvdan / sh

A shell parser, formatter, and interpreter with bash support; includes shfmt

https://pkg.go.dev/mvdan.cc/sh/v3

BSD 3-Clause "New" or "Revised" License

7.29k stars 345 forks source link

interp: fix a PATH regression on Windows, fix tests on Wine #769

Closed mvdan closed 2 years ago

mvdan commented 2 years ago

(see commit messages - please do not squash)

Fixes #768.

mvdan commented 2 years ago

FYI @cclerget @riacataquian @andreynering @glumia

cclerget commented 2 years ago

Oops sorry for the inconvenience !

We had no tests for this behavior, and any script using Unix-like paths in any non-trivial way would likely need to be adjusted to be compatible with Windows anyway.

Yes, handling PATH specifically breaks consistency with other PATH like variables