all: make tests pass on the debian-minimal docker image

mvdan / sh

A shell parser, formatter, and interpreter with bash support; includes shfmt

https://pkg.go.dev/mvdan.cc/sh/v3

BSD 3-Clause "New" or "Revised" License

7.15k stars 338 forks source link

all: make tests pass on the debian-minimal docker image #775

Closed mvdan closed 2 years ago

mvdan commented 2 years ago

(see commit message)

Fixes #773.

mvdan commented 2 years ago

@talau this makes the tests pass for me on debian:11.1-slim on Docker, where they used to fail before, with similar errors as yours. Can you confirm this fix is enough for you?

I want to release v3.4.2 before the holidays, so I could backport this fix as well.

talau commented 2 years ago

Hi there!

I tested on Debian and it's fixed the issue! Thanks @mvdan!

You can see the log here: https://salsa.debian.org/talau-guest/shfmt-tests-minimal/-/jobs/2277914/raw

By the way, shfmt has already been sent to Debian. As it is a new package, it went to the NEW queue, I believe that in a few weeks it will be approved. You can see it here: https://ftp-master.debian.org/new/shfmt_3.4.1-1.html

Regards, mt

mvdan commented 2 years ago

Thanks for confirming! Merging then. You can subscribe to releases if you'd like to be notified when v3.4.2 is out.

riacataquian commented 2 years ago

I missed to review this but I agree with the changes. Thanks for fixing! On my machine, this will still run on the fallback en_US.