search

mvdan / sh

A shell parser, formatter, and interpreter with bash support; includes shfmt
https://pkg.go.dev/mvdan.cc/sh/v3
BSD 3-Clause "New" or "Revised" License
7.14k stars 338 forks source link

v3.5.0 failed to push to Docker Hub #860

Closed mvdan closed 2 years ago

mvdan commented 2 years ago

https://github.com/mvdan/sh/runs/6388354551?check_suite_focus=true

The version check thankfully caught that I messed up with the version stuff, but unfortunately it only runs on tags, and I strongly prefer not to re-tag v3.5.0.

I could manually build and push the images, but the buildx setup is slightly intricate and only configured as part of CI, so I won't do that either.

Instead, I'll tag v3.5.1 in a week with the docker build fix, so Docker Hub will just lag behind for a little while. Hopefully there will be at least one or two other fixes to include as part of the release.

mvdan commented 2 years ago

If anyone can't wait, you can use a recent digest from the latest tag, which is equivalent - there haven't been any code changes since v3.5.0 in the master branch yet. For example: https://hub.docker.com/layers/shfmt/mvdan/shfmt/latest/images/sha256-a89cee7bbb1ded7543169af3aeff1eba97884177f2c9af766105ecf56792bd61?context=explore

mvdan commented 2 years ago

v3.5.1 out and pushed: https://hub.docker.com/layers/shfmt/mvdan/shfmt/v3.5.1/images/sha256-4ade478a9fe9a8de8631f04bd64c1973a945cf0614a4a9156ef6c624690cc534?context=explore

peikk0 commented 2 years ago

@mvdan hello, can you please also publish a release with prebuilt binaries for v3.5.1?

mvdan commented 2 years ago

Huh, I thought I had done that as part of releasing v3.5.1 - I must have forgotten. Doing it now :)

mvdan commented 2 years ago

Done, thank you for the ping: https://github.com/mvdan/sh/releases/tag/v3.5.1

peikk0 commented 2 years ago

@mvdan thank you!