Closed riacataquian closed 2 years ago
I guess this was always wrong but we never noticed because CI runs MacOS with an older Bash by default, and none of us developed locally with a recent enough MacOS... until now :)
Happy for this to be merged btw - not sure if you added the WIP state on purpose.
An alternative is to only support seconds as units. That's all we really need.
I wanted to keep the intention 😅 removed and fixed, thanks! I was away so I kept this as WIP, will merge now.
Running the tests on master gives me the following error:
I am running on
bash version 5.1.16(1)-release
:The error I suppose, is because of the difference of the sleep syntax on BSD/Unix/MacOS vs on GNU/Linux - the former requires no unit and defaults to seconds, while the latter requires either
smdh
as unitTo fix, fix the
sleep
test builtin to accept either of the syntax and default to seconds when none is foundFinally, modify the tests to run without units so it would pass when ran against real bash