mvdevs / jk2mv

JK2MV - improved, modernized JK2 client and server
https://jk2mv.org
GNU General Public License v2.0
108 stars 33 forks source link

Merge jk2mv's menu code into mvsdk's ui code and general ui/menu improvements #119

Closed Daggolin closed 4 years ago

Daggolin commented 5 years ago

As the title suggests the mvmenu code in the jk2mv repository and the ui code in the mvsdk repository are both based on the jk2 ui code. So instead of maintaining two separate versions of almost the same module code it would be best to merge the mvmenu into the ui code to build both from a shared codebase (mvsdk is a submodule of jk2mv already). When merging both ui codebases various other fixes, improvements and changes to the ui could be made.

Mostly done and ready to be reviewed and merged: https://github.com/Daggolin/jk2mv/commits/mvmenu-ui-merge https://github.com/Daggolin/mvsdk/commits/mvmenu-ui-merge

TriForceX commented 5 years ago

Looks fine for me, except 3 things:

ouned commented 5 years ago

close?

Daggolin commented 4 years ago

Merged since ec783dc6d233dda3610ab5eafd50b9ba699420b8. Closing this.