mvdh7 / PyCO2SYS

Marine carbonate system calculations in Python
https://PyCO2SYS.readthedocs.io
GNU General Public License v3.0
50 stars 9 forks source link

Updated docs. #50

Closed AJSchiller closed 3 years ago

AJSchiller commented 3 years ago

In docs/refs.md, reference WM13 was added. It is cited under opt_k_bisulfate in docs/co2sys_nd.md, but was missing from the reference list.

In docs/co2sys_nd.md, changes were made to the descriptions of some of the options for opt_k_carbonic. The reasons for these are described below, with the corresponding citations as headers (see docs/refs.md for full references).

CW98

Docs state real and artificial seawater used. Methods (p. 659) describe collection and analysis of real seawater samples (see screenshot below), but there is no mention of artificial seawater. ce69ab167adc494794a2b0e5920d9b46

Docs give the ranges 2 < T < 35 °C, 0 < S < 49 for this parameterisation. Formulae used in the code are shown below (results, p. 661). Note that slightly different temperature ranges are given for the two pK formulae. I suggest using the range in which the two overlap, i.e., 2 < T < 30 °C. Note also the statement at the bottom, that the equations hold for salinities up to 40, not 49. 07d942b38e6d40e2a384a56ff5266295


WMW14

Docs state ranges 0 < T < 50 °C, 1 < S < 50. See highlighted line below (p. 16 in WM13). There is no eqn. 33 in the paper, but the contents of Table 6 (in both WM13 and WMW14) appear to correspond to eqns. 34-35, and these are the functions used in the code, so I believe the ranges stated below should be applied to this parameterisation. 13454a05465847559a8881230b0ff5de


SB21

Type of seawater used is not stated in the docs. Materials section (p. 233) in the article states it was real seawater: c5ed964599c74f83a38a8bedc600cd4d