search

mvdkwast / obsidian-copy-as-html

Obsidian plugin: copy document as HTML, including images
MIT License
48 stars 11 forks source link

Incompatible plugin: sheets extended - empty tables when native table processing is enabled #65

Closed Bakr2030 closed 4 months ago

Bakr2030 commented 4 months ago

Describe the bug The markdown tables should be rendered as html tables, but is broken.

To Reproduce Steps to reproduce the behavior:

  1. open any simple markdown file with simple tables,
  2. select all, or copy document as HTML
  3. paste in MSWORD, and notice tables are gone !!!

Expected behavior The markdown tables should be rendered as html tables, but is broken.

Screenshots image

Desktop (please complete the following information): i use clean installation of windows 11 and latest obsidian and latest plugin updates.

mvdkwast commented 4 months ago

Hi @Bakr2030,

Thanks for your report. I tried reproducing this, but in my case it seems to work.

Clean Obsidian 1.6.3, only this plugin activated : image

Result in Word (version 2405, windows 11): image

  1. Are you sure that you're using this plugin and not this one : https://github.com/jenningsb2/copy-as-html
  2. Can you attach the markdown source document here to help me reproduce ?
Bakr2030 commented 4 months ago

it could be attributed to a hidden conflict with another plugin, attached is my profile file of plugin, use the obsidian profile to load it in your environment. profiles.rar https://drive.google.com/file/d/1zHJXwNhn9m97jjiMcdoLJEh9tfQcpuQ2/view?usp=drive_web Note: the other similar plugin - Copy As, is working for me, and I assign to it a different hotkey.

On Fri, 28 Jun 2024 at 11:42, mvdkwast @.***> wrote:

Hi @Bakr2030 https://github.com/Bakr2030,

Thanks for your report. I tried reproducing this, but in my case it seems to work.

Clean Obsidian 1.6.3, only this plugin activated : image.png (view on web) https://github.com/mvdkwast/obsidian-copy-as-html/assets/2441349/f7352e47-3470-4ac2-81c6-87a8b295048d

Result in Word (version 2405, windows 11): image.png (view on web) https://github.com/mvdkwast/obsidian-copy-as-html/assets/2441349/8aace8c3-9130-4826-9202-9fc6a2e358fa

  1. Are you sure that you're using this plugin and not this one : https://github.com/jenningsb2/copy-as-html
  2. Can you attach the markdown source document here to help me reproduce ?

— Reply to this email directly, view it on GitHub https://github.com/mvdkwast/obsidian-copy-as-html/issues/65#issuecomment-2196329816, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDSZ2Z5DNGDQTUDT2S25L3DZJUHUPAVCNFSM6AAAAABJ7B6S56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGMZDSOBRGY . You are receiving this because you were mentioned.Message ID: @.***>

Bakr2030 commented 4 months ago

the issue is still ongoing, i noticed the plugin was updated shortly,, i tried pasting into msword as text, rather than rendered rich text, and this is what i got::

<!DOCTYPE html>

0006 - Comparison table of the alternative engagement routes for investors

The following compares the various alternative engagement routes for investors based on key criteria, providing a clear overview of their characteristics, advantages, disadvantages, suitability, resource requirements, risk sharing, time to implementation, and monitoring and compliance needs. This comparison can help in selecting the most appropriate approach for engaging investors in building a refinery in Cameroon.

so as you see, the table object is empty...

On Fri, 28 Jun 2024 at 17:47, Bakr Masaeed @.***> wrote:

it could be attributed to a hidden conflict with another plugin, attached is my profile file of plugin, use the obsidian profile to load it in your environment. profiles.rar https://drive.google.com/file/d/1zHJXwNhn9m97jjiMcdoLJEh9tfQcpuQ2/view?usp=drive_web Note: the other similar plugin - Copy As, is working for me, and I assign to it a different hotkey.

On Fri, 28 Jun 2024 at 11:42, mvdkwast @.***> wrote:

Hi @Bakr2030 https://github.com/Bakr2030,

Thanks for your report. I tried reproducing this, but in my case it seems to work.

Clean Obsidian 1.6.3, only this plugin activated : image.png (view on web) https://github.com/mvdkwast/obsidian-copy-as-html/assets/2441349/f7352e47-3470-4ac2-81c6-87a8b295048d

Result in Word (version 2405, windows 11): image.png (view on web) https://github.com/mvdkwast/obsidian-copy-as-html/assets/2441349/8aace8c3-9130-4826-9202-9fc6a2e358fa

  1. Are you sure that you're using this plugin and not this one : https://github.com/jenningsb2/copy-as-html
  2. Can you attach the markdown source document here to help me reproduce ?

— Reply to this email directly, view it on GitHub https://github.com/mvdkwast/obsidian-copy-as-html/issues/65#issuecomment-2196329816, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDSZ2Z5DNGDQTUDT2S25L3DZJUHUPAVCNFSM6AAAAABJ7B6S56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGMZDSOBRGY . You are receiving this because you were mentioned.Message ID: @.***>

mvdkwast commented 4 months ago

There were no fixes related to tables in the latest update.

To help me pinpoint the problem you could disable all plugins except this one, and verify that tables works as expected. If it does, you can reenable plugins until you find the conflict.

In addition you can attach a sample .md file that reproduces the problem here.

Thanks !

Bakr2030 commented 4 months ago

Untitled 2.md any simple file , actually all files are suffering from that bug, i am now starting to disable plugins to narrow down the potential conflicting plugin

Bakr2030 commented 4 months ago

I found the culprit plugin that makes conflict:

https://github.com/NicoNekoru/obsidan-advanced-table-xt

mvdkwast commented 4 months ago

Thanks,

I can reproduce the issue, not quite sure why it doesn't work. I'll have to take a look at that plugin, not sure I can make it work without changes on their side.

A work-around is to disable native table processing in Sheets Extended, but I'm pretty sure you want to export HTML with the full table formatting.

Bakr2030 commented 4 months ago

notice the other plug "https://github.com/jenningsb2/copy-as-html" is co-existing nicely with the "https://github.com/NicoNekoru/obsidan-advanced-table-xt" ... check it at your side.. you might have to change how you can capture the DOM, there are different ways... chat GPT will give you hints about it.

mvdkwast commented 4 months ago

you might have to change how you can capture the DOM, there are different ways... chat GPT will give you hints about it.

Oh come on, this is downright insulting. You have no idea what your talking about. If it's so easy, why do I get a support request instead of a pull request ?

Now, to educate you a little about what happens when someone has a request about this plugin :

All this takes time, and most of the time the requests are not about anything that is of personal use to me, but I gladly help when time allows. I don't get paid for this, and I have a busy life. When I get told that I should just let chat GPT do it, this makes me a little angry, as this shows no consideration for the actual work that goes into this.

What you also don't seem to realize is that this plugin adresses some of the shortcomings of @jenningsb2's plugin, which required a more complex rendering pipeline. I would just have used his plugin instead of writing my own. And this means that you can't just say "do the same thing as the other guy", which comes over at best as ignorant, at worst as rude and entitled.

I have actually found a fix for this, it's going to be in the next release.

Bakr2030 commented 4 months ago

you are absolutely right, am only an old school dev, back in 90's ,,, recently tampered with GPT for doing capturing of content, that JS task drove me nuts, then i tried GPT for it, it even drove me more nuts.. lol.. sorry for the misunderstanding.

Keep up the good work.

On Sun, 30 Jun 2024 at 03:41, mvdkwast @.***> wrote:

you might have to change how you can capture the DOM, there are different ways... chat GPT will give you hints about it.

Oh come on, this is downright insulting. You have no idea what your talking about. If it's so easy, why do I get a support request instead of a pull request ?

Now, to educate you a little about what happens when someone has a request about this plugin :

  • I have to investigate and reproduce the problem, often this requires some communication to understand what is wrong.
  • I have to implement a fix
  • I have to make sure that this fix doesn't introduce any regression. This means, verifying that the output still works in gmail, word, and some other software that I use on a daily basis. I also have to make sure that all this still works with all the plugins I support (diagrams, excalidraw, mermaid, tasks) + basic image and svg support.

All this takes time, and most of the time the requests are not about anything that is of personal use to me, but I gladly help when time allows. I don't get paid for this, and I have a busy life. When I get told that I should just let chat GPT do it, this makes me a little angry, as this shows no consideration for the actual work that goes into this.

What you also don't seem to realize is that this plugin adresses some of the shortcomings of @jenningsb2 https://github.com/jenningsb2's plugin, which required a more complex rendering pipeline. I would just have used his plugin instead of writing my own. And this means that you can't just say "do the same thing as the other guy", which comes over at best as ignorant, at worst as rude and entitled.

I have actually found a fix for this, it's going to be in the next release.

— Reply to this email directly, view it on GitHub https://github.com/mvdkwast/obsidian-copy-as-html/issues/65#issuecomment-2198374447, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDSZ2ZZN367SLS72WYJ6TDLZJ5AZTAVCNFSM6AAAAABJ7B6S56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGM3TINBUG4 . You are receiving this because you were mentioned.Message ID: @.***>