search

mvdnes / rboy

A Gameboy Emulator in Rust
MIT License
594 stars 38 forks source link

Cartridge checksum is invalid #4

Closed jens1o closed 6 years ago

jens1o commented 6 years ago

This is what I get after compiling it in release mode.

mvdnes commented 6 years ago

But not in debug mode?

Either way, can you provide the ROM you are trying to load?

jens1o commented 6 years ago

I didn't tried out the debug mode(I'll do that now).

The (gba)ROM is from a third-party, I'm sorry.

Do you have a (really) free ROM I could try out reproducing?

I'm on Windows 10 btw.

jens1o commented 6 years ago

I can only say that the ROM works in VisualBoyAdvance. I get the same error when I do a debug build.

mvdnes commented 6 years ago

Here are a few testing ROMs that should work. http://gbdev.gg8.se/files/roms/blargg-gb-tests/ It could be that VisualBoyAdvance just does not care if this checksum is invalid. If that is true, maybe I should add a flag to ignore these kind of checks.

jens1o commented 6 years ago

Yeah, those worked.

I temporarly disabled that check in the code, but it looks like this emulator only supports gb, but not gba files, because I get this new error after disabling the check: Unsupported MBC type

mvdnes commented 6 years ago

That is correct, only gb and gbc games are supported. I will look into a flag for disabling this check.

jens1o commented 6 years ago

Okay, thank you so much. I really love the idea behind this emulator :)

mvdnes commented 6 years ago

I have added a --skip-checksum flag to the binary.

jens1o commented 6 years ago

Thanks!