search

mvdschee / web-accessibility

A Visual Studio Extension for Web accessibility
https://marketplace.visualstudio.com/items?itemName=MaxvanderSchee.web-accessibility
MIT License
70 stars 13 forks source link

Correct spelling mistakes #23

Closed gilles-leblanc closed 5 years ago

gilles-leblanc commented 5 years ago

I corrected 3 small mistakes in some user facing text in accessibilityPatterns.ts.

The contributing guidelines mentioned to create a pull requests to the dev branch. Upon closer inspection I noticed that the dev branch was lagging behind the master branch. Also there was a commit that was in dev but not in master which required a merge from master to dev.

I tried simply rebasing master unto dev at first but this created a situation where there was a diverging commit when it was time to push, so I felt this merge was better in this situation.

gilles-leblanc commented 5 years ago

I'm not sure how you want to handle the merge of the dev / master branch. I'll reopen this but let me know if you would rather take care of the merge independently from this pull request.

mvdschee commented 5 years ago

@gilles-leblanc Thank you for correcting my spelling and of course helping me keeping my branches up to date. your pull looks good to me so I will merge it and close the pull request.