search

mvdschee / web-accessibility

A Visual Studio Extension for Web accessibility
https://marketplace.visualstudio.com/items?itemName=MaxvanderSchee.web-accessibility
MIT License
70 stars 13 forks source link

Support TSX #42

Closed hm-lee closed 4 years ago

hm-lee commented 4 years ago

Added the following Features:

mvdschee commented 4 years ago

He @hm-lee you're right let's not forget the Typescript version 😄

mvdschee commented 4 years ago

If you could add one more change for me in /client/src/extension.ts around rule 35 { language: 'typescriptreact', scheme: 'file' }, I can accept your pull :)

hm-lee commented 4 years ago

OK! I'll be update it! 👀

hm-lee commented 4 years ago

@mvdschee fixed! 👀

hm-lee commented 4 years ago

@mvdschee hi! is there any update plan exist of the vscode marketplace? I want to share this extensions with the my company team.😊

mvdschee commented 4 years ago

He @hm-lee I will do a hotfix for this one; I haven't fixed enough issues to set up another full-on release, so expect it in like a couple of hours.

mvdschee commented 4 years ago

He @hm-lee you I was checking and it doesn't seem to hit on the <img> for my small test. So you got any project with TypeScript React for me that I can use to test and debug?

hm-lee commented 4 years ago

@mvdschee Oh, I saw it late, my projects are company products... 🤔 so how about the example of the project below? I'll keep looking for better examples. https://github.com/dl0312/react-typescript-boilerplate

mvdschee commented 4 years ago

Hmm I need like a good representation of how a React developer would write it's HTML (obviously that's a per person difference) but I don't use react for that. I can just add it but there's a big change that i wont trigger on any A11y rules, just don't want to give people a false hope of writing accessible code.