search

mvdwetering / aiohuesyncbox

Asyncio package to communicate with Philips Hue Play HDMI Sync Box.
Apache License 2.0
4 stars 0 forks source link

Fix server name check #2

Closed mvdwetering closed 3 months ago

mvdwetering commented 3 months ago

My hacky server name inserter does not work anymore with aiohttp >=3.10.

Luckily support for this feature was added in 3.9 with the server_hostname option.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes streamline the project by updating the GitHub Actions workflow to focus on more recent Python versions, removing support for Python 3.7. Additionally, the CommonNameInserterResolver class was eliminated from the HueSyncBox code, simplifying SSL certificate validation. The requirements.txt file was also modified to ensure compatibility with a specific range of aiohttp, enhancing stability while utilizing new features.

Changes

Files Change Summary
.github/workflows/python-package.yml Updated python-version matrix to remove Python 3.7, now supporting only versions 3.8 to 3.12.
aiohuesyncbox/huesyncbox.py Removed CommonNameInserterResolver class and _mangled_host method, simplifying SSL handling.
requirements.txt Updated aiohttp version constraint to >=3.9.0,<4, ensuring compatibility with newer features.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HueSyncBox
    participant SSLManager

    User->>HueSyncBox: Initiate Request
    HueSyncBox->>SSLManager: Validate SSL with self._id
    SSLManager-->>HueSyncBox: SSL Validation Result
    HueSyncBox-->>User: Return Response

🐰 In the meadow, bunnies cheer,
Python's newer versions near.
Old 3.7, now out of sight,
SSL's simpler, what a delight!
Aiohttp's range now holds so true,
Hopping forward, we code anew! 🎉

Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.