Closed mvdwetering closed 2 months ago
The recent changes enhance the Yamaha YNCA integration by refining the handling of entity registration and improving the clarity of command transmission in the YamahaYncaZoneRemote
class. The test suite has also been updated to reflect these changes, ensuring better alignment with actual device behavior and simplifying the test setup process.
File Path | Change Summary |
---|---|
custom_components/yamaha_ynca/... |
Removed _attr_entity_registry_enabled_default from YamahaYncaZoneRemote . Updated send_command method to use formatted_code for clarity in API calls. |
tests/conftest.py |
Added entity_registry_enabled_by_default fixture to ensure entities are enabled during tests. Removed enable_all_entities parameter from setup_integration . |
tests/test_number.py |
Updated test values for hpbass and hptreble , changed expected entities count from 4 to 6, added fixture to test_number_entity_volume , and refined entity name. |
sequenceDiagram
participant User
participant YamahaYncaZoneRemote
participant API
User->>YamahaYncaZoneRemote: Send Command
YamahaYncaZoneRemote->>YamahaYncaZoneRemote: Format Remote Code
YamahaYncaZoneRemote->>API: Call with Formatted Code
API-->>YamahaYncaZoneRemote: Acknowledge Command
YamahaYncaZoneRemote-->>User: Command Successful
🐇 In the garden of code, we hop with glee,
Changes abound, as bright as can be!
With clearer commands and tests that align,
Our Yamaha's magic is truly divine.
Hooray for the updates, let's dance and play,
For a smoother tomorrow, hip-hip-hooray! 🎉
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests