mvdwetering / yamaha_ynca

Custom integration for Home Assistant to support Yamaha AV receivers with the YNCA protocol (serial and network).
Apache License 2.0
40 stars 4 forks source link

Dont hide remote entity by default #304

Closed mvdwetering closed 2 months ago

mvdwetering commented 2 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent changes enhance the Yamaha YNCA integration by refining the handling of entity registration and improving the clarity of command transmission in the YamahaYncaZoneRemote class. The test suite has also been updated to reflect these changes, ensuring better alignment with actual device behavior and simplifying the test setup process.

Changes

File Path Change Summary
custom_components/yamaha_ynca/... Removed _attr_entity_registry_enabled_default from YamahaYncaZoneRemote. Updated send_command method to use formatted_code for clarity in API calls.
tests/conftest.py Added entity_registry_enabled_by_default fixture to ensure entities are enabled during tests. Removed enable_all_entities parameter from setup_integration.
tests/test_number.py Updated test values for hpbass and hptreble, changed expected entities count from 4 to 6, added fixture to test_number_entity_volume, and refined entity name.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant YamahaYncaZoneRemote
    participant API

    User->>YamahaYncaZoneRemote: Send Command
    YamahaYncaZoneRemote->>YamahaYncaZoneRemote: Format Remote Code
    YamahaYncaZoneRemote->>API: Call with Formatted Code
    API-->>YamahaYncaZoneRemote: Acknowledge Command
    YamahaYncaZoneRemote-->>User: Command Successful

Poem

🐇 In the garden of code, we hop with glee,
Changes abound, as bright as can be!
With clearer commands and tests that align,
Our Yamaha's magic is truly divine.
Hooray for the updates, let's dance and play,
For a smoother tomorrow, hip-hip-hooray! 🎉


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.