search

mvdwetering / ynca

Python library to communicate with Yamaha AV Receivers that support the YNCA protocol
MIT License
12 stars 5 forks source link

Improve SubunitBase tests to use Enums instead of Str ids #10

Closed mvdwetering closed 1 year ago

mvdwetering commented 1 year ago

With the introduction of Python 3.11 some bahviour of Enum.format was changed, but not detected by the tests.

That should be detected by the SubunitBase test(s), but since they use Str as the id in the DummySubunit there was no Enum to convert. A quick replacement did still not detect the issue. Hence this ticket to have a deeper look at it at some point.

See PR #9 for more details.

mvdwetering commented 1 year ago

Solved by adding a basic end-to-end integration test in 84957a6245fe033bc35bfd311bb76a045a61885e