mvdwetering / ynca

Python library to communicate with Yamaha AV Receivers that support the YNCA protocol
MIT License
12 stars 5 forks source link

Add preset support for dab tuner #13

Closed mvdwetering closed 3 months ago

mvdwetering commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The overall change involves enhancing the yamaha_ynca custom component for Home Assistant, specifically focusing on the Yamaha RX-V500D receiver. It includes logging integration efforts, adding and testing new functionalities for DAB and FM presets, and adjusting internal handling for enums and function conversions. These updates aim to improve the receiver's interoperability with Home Assistant, offering more detailed control and feedback for users.

Changes

Files Summary
logs/RX-V500D.txt Detailed logs for Yamaha RX-V500D receiver integration with Home Assistant using yamaha_ynca.
tests/test_dab.py Added tests for DAB and FM presets functionality.
tests/test_enums.py
ynca/enums.py
Added DabPreset and FmPreset enums with tests for handling invalid values.
ynca/function.py Adjusted converter setup for Enum and Float conversions.
ynca/server.py Modified handle_put to assume support for "MEM" function without response generation.
ynca/subunits/dab.py Enhanced DAB subunit with new properties and mixins for DAB and FM presets.

🐇✨
In the land of code and wire,
A rabbit hopped, with dreams so dire.
To meld the sound, the tunes, the choir,
With code that sings, on digital pyre.
Through tests and enums, it leapt, inspired—
A symphony of bytes, in harmony conspired.
🎶🌟


Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.