search

mverleg / pyjson_tricks

Extra features for Python's JSON: comments, order, numpy, pandas, datetimes, and many more! Simple but customizable.
Other
153 stars 23 forks source link

Add support for pathlib #54

Closed bburan closed 5 years ago

mverleg commented 5 years ago

Great addition, I wasn't aware of pathlib! And thanks for doing the implementation!

The changes are good, follow the setup of other encoders/decoders well.

There are just a few things left to do:

I could have a look this weekend to do the finishing touches, if you don't have time. I appreciate that you already did almost all the work :+1:

bburan commented 5 years ago

I'm not an expert on tox, so I wasn't sure what to do. I updated the pathlib test to hide it inside an if is_py3 block, but it looks like tox is smart enough to only run certain tests depending on the Python version? I think I addressed all the other comments you have, so please let me know if there's anything else. Thanks for taking the time to review this!

mverleg commented 5 years ago

Okay looks great! I'll have a look at tox after merging, and add you to the contributors. Thanks for the PR!

mverleg commented 5 years ago

This feature is available in the latest version through pip

bburan commented 5 years ago

Thanks!

On Sat, Mar 2, 2019 at 3:31 PM Mark notifications@github.com wrote:

This feature is available in the latest version through pip

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mverleg/pyjson_tricks/pull/54#issuecomment-468970642, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT5QtuCqKwTyw8C3PfUAFWvXmM9uUnsks5vSwnbgaJpZM4bS9If .