search

mvexel / overpass-api-python-wrapper

Python bindings for the OpenStreetMap Overpass API
Apache License 2.0
359 stars 89 forks source link

Relation and multipolygon support #115

Closed lukasmu closed 4 years ago

lukasmu commented 4 years ago

This pull request can be considered a follow-up to https://github.com/mvexel/overpass-api-python-wrapper/pull/76.

I initially started to resolve the merge conflict referenced in the pull request mentioned above. But then I decided to rewrite and optimize the geojson parsing method completely.

Finally I added a test based on real data to make sure that the parsing works correctly.Please note that the example.json file in the tests folder can be opened with any geojson viewer.

lukasmu commented 4 years ago

A note on the Travis checks: For Python 2.7 the error occurs due to differences in pickle functionalities that are solely used in the tests. I don't think this is worth fixing anymore (see https://www.python.org/doc/sunset-python-2) For Python 3.3 there seems to be something wrong with the Travis config

ThomDietrich commented 4 years ago

Thanks for the latest commit. All my comments are addressed 👍💯

ThomDietrich commented 4 years ago

@mvexel @tbolender @t-g-williams What do you think? Anything holding back a merge soon? Best!

lukasmu commented 4 years ago

@tbolender @mvexel Is there still anything that I can improve on this pull request? Or did you just not yet have the time to look into it?

tbolender commented 4 years ago

From my side everything is okay. I waited since I wanted @mvexel to have a look at it.

mvexel commented 4 years ago

Sorry guys I've been unavailable.. I'll have a look.