search

mvexel / overpass-api-python-wrapper

Python bindings for the OpenStreetMap Overpass API
Apache License 2.0
359 stars 89 forks source link

improve unittests and fix strptime of status datetime for 3.6 #145

Closed Vitalts closed 4 months ago

Vitalts commented 2 years ago

• mock all requests to real overpass endpoint in unittests • refactor unittests • add more unittests • fix strptime of status datetime for 3.6

mvexel commented 2 years ago

Hi @Vitalts - after merging @dericke 's PR https://github.com/mvexel/overpass-api-python-wrapper/pull/141 there are some minor merge conflicts, could you resolve and then I can merge, please?

dericke commented 2 years ago

We've dropped py3.6 support since this PR was opened, so the parts related to that shouldn't be merged.

mvexel commented 2 years ago

@Vitalts Are you still interested in getting this merged? See also @dericke's comment. Sorry for the slow turnaround.. Let me know if I can help in any way.

mvexel commented 6 months ago

@dericke @Vitalts how would you like to proceed with this, in light of the significant changes in test_api.py in #140 ?

dericke commented 6 months ago

I won't be able to spend any time on this for a couple of weeks, but I'll check in and see how I can help out at that point.

dericke commented 5 months ago

Everything in the files I didn't comment on looks to still be relevant at first glance (and great work there!) but I haven't run any of the tests yet to be sure.

mvexel commented 5 months ago

@Vitalts are you still interested in getting this over the finish line? I'm sorry it all took so long.. With @dericke 's comments we are one step closer.

mvexel commented 4 months ago

so @dericke @Vitalts This branch has diverged from main enough that merging will be a bit of a mess. I could use some help especially with api.py

Anyone has some time to spend on this? Or should we abandon this PR and start a new one focused on fixing the tests and deprecating 3.6?

dericke commented 4 months ago

I would be in favor of closing this PR and opening a new one focused just on the tests.

mvexel commented 4 months ago

thanks @dericke , I will close this then and create an issue that we can create a new PR against.