search

mvexel / overpass-api-python-wrapper

Python bindings for the OpenStreetMap Overpass API
Apache License 2.0
368 stars 90 forks source link

Adding version to the geojson elements #156

Closed viksuper555 closed 7 months ago

viksuper555 commented 1 year ago

Fixes #155

viksuper555 commented 1 year ago

I would like to hear your feedback on this.

P.S. The tests seem broken, although my changes don't really affect them.

mvexel commented 1 year ago

Hi, thanks for this! I'll have a look.

mvexel commented 8 months ago

Sorry @viksuper555 I have been so busy with life things. I'll have a look!

mvexel commented 8 months ago

version is already available in the feature properties when get() is called with verbosity="meta": https://github.com/mvexel/overpass-api-python-wrapper/blob/main/overpass/api.py#L315

We can discuss if that is the right place for it, but I would like to avoid having the same information in the output twice. Thoughts?

mvexel commented 7 months ago

@viksuper555 As commented on #155 -- this information is available so I will not merge this. Thanks for the effort though, and if you have any concerns with the way the metadata is exposed, don't hesitate to come back and discuss.