mvexel / overpass-api-python-wrapper

Python bindings for the OpenStreetMap Overpass API
Apache License 2.0
367 stars 90 forks source link

pep8 compliance, implementing raw_query #24

Closed mvexel closed 9 years ago

mvexel commented 9 years ago

This PR:

mharnold commented 9 years ago

Never mind! I figured out 'function-names' is the branch.

mharnold commented 9 years ago

What I had in mind was just renaming _GetFromOverpass() to raw_get()

mvexel commented 9 years ago

I think the GeoJSON output is still relevant even if you want to perform a raw query.

mharnold commented 9 years ago

Then the caller would need to know to use a query that uses json response format and sets geom print option to avoid an exception during conversion to geoJSON. It seems simpler to me to have the geoJSON output option only on our higher level get() and leave the raw_get solely to users who want full unadorned access to the overpass API.

But maybe you have a use case in mind for a raw_get() with a geoJSON option?

Cheers, Michael spiderOSM.org

On Tue, Nov 25, 2014 at 8:54 PM, Martijn van Exel notifications@github.com wrote:

I think the GeoJSON output is still relevant even if you want to perform a raw query.

— Reply to this email directly or view it on GitHub https://github.com/mvexel/overpass-api-python-wrapper/pull/24#issuecomment-64514979 .

mvexel commented 9 years ago

Not really - I think you are right, there is no need to have asGeoJSON in the raw query.

BTW here is the script I was talking about, using this wrapper to connect Overpass and MapRoulette.

mharnold commented 9 years ago

Very cool! I have an application in mind but it would require map roulette to serve up challenges near the users currrent location. Not sure this is currently possible in maproulette?

My application: have users resolve name mismatches between OSM and jurisdictional data by survey (checking out street signs at the location.) See: http://names.mhaprojects.com/about.html