search

mvextensions / mvbasic

MultiValue Basic extension for Visual Studio Code
MIT License
30 stars 16 forks source link

[FEATURE] Update Naming Conventions #22

Closed itsxallwater closed 5 years ago

itsxallwater commented 5 years ago

Is your feature request related to a problem? Please describe. The project still references MVON and ONgroup. Need to update to change MVON references to MV Basic and ONgroup references to MV Extensions.

Describe the solution you'd like Make the name changes, specifically focusing on extension configuration names and publisher info but elsewhere as acceptable/necessary.

An example where not necessary, the client\Syntaxes\MvLanguage.json file referencing "MVON# Basic" as a Language type.

An example where necessary, the client\src\extension.ts file referencing "mvon" as the configuration namespacece

itsxallwater commented 5 years ago

Note that @CharlesBarouch is in progress on this so assigning to him!

dthiot commented 5 years ago

I took much of the reference to ONgroup and MVON# out of the documentation. However, I wasn't exactly sure how to replace it and chose MVextensions.

itsxallwater commented 5 years ago

@CharlesBarouch thanks for the commit, I've not yet had a chance to look but will try to do so and get you notes. @GrantHart if you wanted to peek here's just a tag to give you a heads up that Chuck got some name changes committed for the team to review w/ commit https://github.com/mvextensions/mvbasic/commit/15998ccabc29f83e4bca24d5dfd25c0df140b1e2.

itsxallwater commented 5 years ago

Name changes have been pushed to master. Thanks @CharlesBarouch!