mveytsman / heroicons_elixir

Phoenix components for Heroicons! 🛡️
MIT License
118 stars 28 forks source link

Liveview (0.19) & deps updated #25

Closed nathanmalishev closed 1 year ago

nathanmalishev commented 1 year ago

Updated mix to use Liveview 0.19 and updated other decencies as well.

Modified the test that checks the 'Global attribute' docs as it must have changed as well. (test/heroicons_test.exs:96).

Issue - https://github.com/mveytsman/heroicons_elixir/issues/24

dovadi commented 1 year ago

Concerning the failing "generating docs" test: since phoenix_live_view 0.18.4 the function build_attrs_docs is changed. In case of a global attribute you can't declare documentation for the attribute anymore, it just returns "* Global attributes are accepted.\n".

It seems inconsistent, because in the phoenix_live_view library itself in case of a global attribute document information is still provided

You can see this in the documentation of Phoenix LiveView as well. Note the difference in the documentation of the attributes of for example form/1

https://hexdocs.pm/phoenix_live_view/0.18.3/Phoenix.Component.html#form/1

screenshot_0_18_3_form_attributes

and

https://hexdocs.pm/phoenix_live_view/0.18.4/Phoenix.Component.html#form/1

screenshot_0_18_4_form_attributes

mveytsman commented 1 year ago

Thank you ❤️ ❤️ ❤️