search

mveytsman / heroicons_elixir

Phoenix components for Heroicons! 🛡️
MIT License
118 stars 28 forks source link

Update to use phoenix_live_view 0.20 #31

Closed tapickell closed 10 months ago

tapickell commented 10 months ago

This is something we ran into when needing to upgrade our application to use the latest LiveView. All of our Icons work fine.

mveytsman commented 10 months ago

@tapickell what was the issue you had before? It looks like >= 0.18.2 should still support 0.20.0 but this requirement would make it incompatible with older versions of liveview.

tapickell commented 10 months ago

@tapickell what was the issue you had before? It looks like >= 0.18.2 should still support 0.20.0 but this requirement would make it incompatible with older versions of liveview.

@mveytsman the >= 0.18.2 unfortunately did not allow for Liveview 0.20.0 and caused an issue with the dependencies.

❯ mix deps.get
Resolving Hex dependencies...
Resolution completed in 0.248s
Because the lock depends on heroicons 0.5.2 which depends on phoenix_live_view ~> 0.18.2, the lock requires phoenix_live_view ~> 0.18.2.
And because your app depends on the lock, phoenix_live_view ~> 0.18.2 is required.
So, because your app depends on phoenix_live_view ~> 0.20.2, version solving failed.
** (Mix) Hex dependency resolution failed

I would not want to introduce a change that would block backwards compatibility with older versions. We are now using our fork to be able to upgrade to LIveview 0.20.0 If there is a different change that would be better or if there is something maybe I missed that would allow the 0.20.0 update without changing anything here I am all ears. Thank you.

mveytsman commented 10 months ago

Hey Todd no need to close this, will look into it today or tomorrow! On Wed, Jan 3, 2024 at 12:28 PM Todd Pickell @.***> wrote:

Closed #31 https://github.com/mveytsman/heroicons_elixir/pull/31.

— Reply to this email directly, view it on GitHub https://github.com/mveytsman/heroicons_elixir/pull/31#event-11381559410, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIPIELOXAK543VLC4LDYTYMWINVAVCNFSM6AAAAABBEQTNBWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGM4DCNJVHE2DCMA . You are receiving this because you were mentioned.Message ID: @.***>

mveytsman commented 10 months ago

@tapickell as you may have found,0.5.3 is compatible with phoenix 0.20.0 without losing backwards compatibility. See https://github.com/mveytsman/heroicons_elixir/commit/13fe5eb37d5a78dc2b001c8a8f192bbe1ef47666

I can confirm, as I just bumped my current app here and am getting no errors. Hope that fixed it for you!