search

mvf / qolibri

Continuation of the qolibri EPWING dictionary/book reader
GNU General Public License v2.0
172 stars 13 forks source link

Don't display duplicate entries #17

Open SpongebobSquamirez opened 5 years ago

SpongebobSquamirez commented 5 years ago

For a lot of dictionaries, Qolibri only shows the first part of an entry under a headword unless you read the book data directly. However, even then, it duplicates a lot of parts of entries (sub-headwords?) for these types of dictionaries for some reason: QolibriFull

(interestingly, the [3] part and the 例文 part are not duplicated)

This means that I can only see less than half of the entries I should be able to at once (this is all supposed to be part of the same entry - EBPocket on my phone displays this stuff fine). It also requires I develop some kind of skill for skipping over the duplicates.

(dictionary in the picture is the 日本語表現活用辞典 EPWING, if you have it)

mvf commented 5 years ago

Many thanks for the detailed report. I can reproduce the problem. The duplicate entries are certainly annoying, but personally I find the missing ones even more serious.

SpongebobSquamirez commented 5 years ago

Thanks for responding! Glad the issue got noticed. EBWin4 and its equivalents seems to display everything well, if you want something on desktop to test with.

pkmkb005 commented 4 years ago

It's also perfectly being rendered in DDwin and Logophile. So it must be an issue with libeb itself. Edit: The dictionary is properly being rendered in Digdic digdic

Digdic also uses eb library and is open source. https://osdn.net/projects/digdic/ If possible please take a look at the source code. Unfortunately I'm not a programmer and don't know anything about programming, just made this account to report this issue.

mvf commented 4 years ago

@pkmkb005 You are a legend, thanks so much for this great info! I wasn't aware of DigDic. I had only tested with EBView and it renders the same as qolibri, so I was convinced this was a libeb issue.

I just coerced DigDic into building and running on modern Linux and it does indeed render correctly. So this should be fixable in qolibri itself after all.

(Sorry I only saw this today by accident. Editing a comment without adding a @mention doesn't send an email notification.)

mvf commented 4 years ago

Being able to debug digdic and qolibri side by side, I now have some idea why the search result is cut off. Haven't yet looked at the duplication when reading the whole book. I really hope this can be fixed cleanly without extensive rewrites... WIP screenshot:

issue17

pkmkb005 commented 4 years ago

@mvf cheers.