mvf / qolibri

Continuation of the qolibri EPWING dictionary/book reader
GNU General Public License v2.0
168 stars 13 forks source link

Books not found in non-ASCII paths #18

Closed satmanprime closed 4 years ago

satmanprime commented 4 years ago

I am not sure if there is something wrong with my epwing files but whenever I try to add them to qolibri I get this message "1 books (-1subbook) found: 0 books added. Any help as to what is jappening and how to fix it would be greatly appreciated.

satmanprime commented 4 years ago

Holy crap I am so dumb. It was because the folder names were in japanese. This took me so long to figure out.

mvf commented 4 years ago

Thanks for reporting this. Of course it's qolibri that's dumb for not finding your files. This is a regression from 1.x. It's working on Linux and macOS.

mvf commented 4 years ago

Should be fixed with 2.1.3. Turns out this didn't fully work in 1.x either: Which special characters were supported depended on the Windows installation language.

ONEsuzuki commented 1 year ago

Holy crap I am so dumb. It was because the folder names were in japanese. This took me so long to figure out.

Just Curious, where the names In japanese english, or actual japanese. Since I'm experiencing the same problem, if It persists are try installing the continuied version of git hub many thanks. EDIT; I know it's a windows issue but just wonder Thanks.

mvf commented 1 year ago

@Ethan1978 This is not about Japanese, but rather about whether the path has characters outside the system's code page. Only Unicode can represent all characters, and Windows apps have to jump through some extra hoops for that.

Switching to this qolibri fork will fix your issue. If you prefer to stay on qolibri 1.x, it's easily fixable there too, no programming needed. Only requirement is that you're on Windows 10 or later.

ONEsuzuki commented 1 year ago

Thanks for getting back to me, are are try the latest fork thank you

On Tue, 16 Aug 2022, 18:02 Matthias von Faber, @.***> wrote:

@Ethan1978 https://github.com/Ethan1978 This is not about Japanese, but rather about whether the path has characters outside the system's code page. Only Unicode can represent all characters, and Windows apps have to jump through some extra hoops for that.

Switching to this qolibri fork will fix your issue. If you prefer to stay on qolibri 1.x, it's easily fixable there too, no programming needed. Only requirement is that you're on Windows 10 or later.

— Reply to this email directly, view it on GitHub https://github.com/ludios/qolibri/issues/18#issuecomment-1216910054, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2QBT326TW3OELVSWMUZBV3VZPCTTANCNFSM4IZK2IQQ . You are receiving this because you were mentioned.Message ID: @.***>