search

mvf / qolibri

Continuation of the qolibri EPWING dictionary/book reader
GNU General Public License v2.0
168 stars 13 forks source link

Add more japanese translations #22

Closed werererer closed 4 years ago

werererer commented 4 years ago

I added more translations

mvf commented 4 years ago

Thanks for the PR! There were some issues that were quicker cleaned up than explained. If you're cool with my changes, I will merge this. This PR also made me aware of the fact that we're currently missing contribution guidelines. This will be tracked in #24.

A note on translations: I appreciate the effort but I'd suggest not spending any additional time improving the current translation. #13 will change some of the wording and UI internals, making much of the translation work done on the current version obsolete.

werererer commented 4 years ago

Yeah I'm fine with the changes in the PR.