search

mvf / qolibri

Continuation of the qolibri EPWING dictionary/book reader
GNU General Public License v2.0
168 stars 13 forks source link

Clipboard monitoring issue #26

Closed MrPiethon closed 3 years ago

MrPiethon commented 4 years ago

Hi Ludios,

Thanks for picking up the project, I just wanted to let you know of a small issue with the clipboard monitoring. If we have another program open (JGlossator) that monitors the clipboard, it seems to affect qolibri from monitoring the clipboard.

However, if I were to ctrl + c several times, then it would finally pick up the word and show up in qolibri.

Not the end of the world, but it would be nice to have the clipboard monitoring work on the first try 90%+ of the time.

Environment: Windows 10 64bit qolibri (2.1.3, win32)

mvf commented 4 years ago

Thanks for reporting this. Turns out it's an issue with the Qt framework qolibri is using (QTBUG-53979). Upon receipt of a WM_CLIPBOARDUPDATE message, Qt will try to retrieve the updated clipboard contents, which can fail if another application has the clipboard locked at the same time. Starting with version 5.14, Qt will retry 3 times with a 50 ms delay, which seems to make it work with JGlossator.

Unfortunately, while testing the 2.1.3 Windows release, I found that with Qt 5.14, after opening a web search, clipboard monitoring stops working completely until the application is restarted. That's why 2.1.3 is built against 5.13 on Windows.

It will take a while to address this issue with Qt upstream. In the meantime I added a Qt 5.14 based build to the 2.1.3 release. As long as you're not using web searches, it might improve your situation.

MrPiethon commented 4 years ago

Hi Matthias,

Thanks for the speedy response and fix, I did some preliminary testing with both of them open and it seems to work very well. I'll have some more time to actually look into it later today.

As for the issue with web search, it's definitely something I can live without. Thanks so much!

MrPiethon commented 4 years ago

It's seems like it is working well :)

mvf commented 4 years ago

Cheers for the feedback! I updated the 2.1.3 release notes.

MrPiethon commented 4 years ago

Hi @mvf would you like me to close out the issue or keep it open?

mvf commented 4 years ago

Hi @MrPiethon Totally up to you. If this is resolved from your PoV and you want it off your open issues list, feel free to close this issue. I would then open a new one though, since we still need a proper fix.

MrPiethon commented 3 years ago

No worries, I have no issue with keeping this open until a proper fix is released. I hope you have a wonderful 2021!

mvf commented 3 years ago

2.1.4 will be built against Qt 5.15.2, where all of this is fixed. Thanks for your patience and all the best to you too! 😉