search

mvf / qolibri

Continuation of the qolibri EPWING dictionary/book reader
GNU General Public License v2.0
172 stars 13 forks source link

Port to Qt WebEngine (fixes Windows build) #5

Closed mvf closed 5 years ago

mvf commented 5 years ago

(Relates to #4)

For displaying web pages, qolibri was using the Qt WebKit library, which was removed years ago with Qt 5.6. These days it's pretty much only still available on GNU/Linux and the BSDs, where distros maintain it to keep old apps working for now.

This PR ports to Qt WebKit's Chromium-based successor Qt WebEngine.

Among other things, this fixes Windows builds (only tested with official prebuilt Qt 5.11.2 on Windows 10 x64 with VS2017 compiler):

qolibri-win

ivan commented 5 years ago

Thanks so much for fixing this and sending the PR. I didn't see any regressions on Debian, so I am going to push a commit with this merged shortly.