search

mvgrimes / obsidian-todotxt-plugin

Obsidian plugin to manage todotxt files
MIT License
54 stars 4 forks source link

Priority tag on completed tasks breaks filtering, rendering #16

Closed Serneum closed 1 year ago

Serneum commented 1 year ago

This may be intentional, but I've noticed that the priority of a ToDo item is saved as a tag pri: and removes it from how I had originally set it (ex: (A)), which seems to cause issues with modifying the item after it has been completed. For example, if I complete an item but then want to change the context or project, the tag shows up and then when saved, it does not render with the little priority bubble. When modifying a ToDo item that has not been completed, this does not seem to be an issue at all.

This also occurs when using todo.sh archive later: image

This causes the priority filter to not work as expected and I need to set it to All to see the tasks that were completed. Maybe that's okay, it just struck me as odd

Serneum commented 1 year ago

It looks like this may be intentional per the code and todo.txt syntax so I will close this.

mvgrimes commented 1 year ago

Yes this is intentional, but it really was just part of an experimental feature that I'll be releasing in 1.3.4: when the "Preserve Priority" feature is enabled, tasks that are toggled to not completed will have their priority restored from the pri: tag.

As for displaying tasks, if a task had a priority equal to or higher than the priority filter, it is shown for a time after being marked complete. Once the file has been reloaded, completed tasks are hidden regardless of their (former) priority.