search

mvied / wordpress-https

WordPress HTTPS is intended to be an all-in-one solution to using SSL on WordPress sites.
http://wordpress.org/extend/plugins/wordpress-https/
95 stars 41 forks source link

Update Core.php to fix an error with a deprecated function 'force_ssl_login' #45

Closed rickcurran closed 8 years ago

rickcurran commented 8 years ago

Changed 'force_ssl_login' to 'force_ssl_admin' to fix an error caused since WordPress 4.4 came out. Reference: https://wordpress.org/support/topic/breaks-site-after-wp-44-update?replies=4

ldaidone commented 8 years ago

Hi @rickcurran,

I didn't see you PR before, I also created a new PR (https://github.com/mvied/wordpress-https/pull/48) that includes your fix and backward compatibility, in addition to missing curly brackets fix.

BTW, is this an active project?

Regards,

Leo.

rickcurran commented 8 years ago

Hi @ldaidone, my PR was submitted over a month ago, I've tried contacting the developer via twitter but had no response, so the project is not very active but is however in popular usage so it would be good to get it updated.

jpSimkins commented 8 years ago

I too am needing this updated. I already made this edit myself but saw https://github.com/mvied/wordpress-https/pull/48 so I will be testing this out too.

I'll probably just do a fork and maintain this on my own account for future updates since this seems to be a dead project.

headstash commented 8 years ago

Thanks for this update. I'm currently testing this version with 4.4 extensively so that I can release it to the public.

I will also be creating a roadmap for the project so that others will know how to contribute. I still don't have a ton of time to spend on it, but I would at least like to get it back to a well-managed state.

Thanks again.

jpSimkins commented 8 years ago

:+1: