Closed eine closed 5 years ago
I just want to note that this is a good suggestion and I still have it in mind. Thank you!
I am still hesitating because it is more work than it looks on the first glance.
It changes an essential functionality that must work reliable in any case.
I often have hassle with common linux commands that behave different on different systems. So I have to check out the behaviour of tar
on many linux systems first before implementing it in the update routine.
I am still hesitating because it is more work than it looks on the first glance. It changes an essential functionality that must work reliable in any case.
Is it 'more work' because many things need to be changed or just because of the effects it might have?
I often have hassle with common linux commands that behave different on different systems. So I have to check out the behaviour of
tar
on many linux systems first before implementing it in the update routine.
Did you find any particular issue with tar? I found the following to be quite portable:
mkdir $TARGET_PATH
curl -fsSL https://codeload.github.com/mviereck/x11docker/tar.gz/master | tar xzf - --strip-components=1 -C $TARGET_PATH
Is it 'more work' because many things need to be changed or just because of the effects it might have?
The installer()
function is rather short and simple.
The work is to check its functionality on several different linux systems.
If an option like e.g. --clipboard
would fail somewhere, it is a minor issue and does not affect core x11docker functionality.
If --update
fails, it breaks x11docker entirely. So I hesitate to touch it.
Did you find any particular issue with tar?
I rarely used tar
at all. I just found that I can't rely on the same syntax or same result of many common linux commands on several systems. I even found one POSIX command that does not work everywhere (logname
).
I could create a bunch of different containers based on as much different systems as possible and check tar
in them. Some day.
I have included tar
support now. I did some tests on some systems, and its syntax has been the same on all of them. The download pathes are changed to codeload.github.com
.
Thanks for your suggestion!
I just tested it and it works great. Thanks!
Thanks for the feedback!
Currently unzip is required in order to install x11docker:
The check is done in https://github.com/mviereck/x11docker/blob/master/x11docker#L1084, and
unzip
is used in https://github.com/mviereck/x11docker/blob/master/x11docker#L1100. In between, the repo is downloaded in zip format.There are two issues here:
https://codeload.github.com/mviereck/x11docker/zip/master
is used to download--update-master
, buthttps://github.com/mviereck/x11docker/archive/$Releaseversion.zip
is used for--update
. Why not use the same for both? According to adobe/git-server#5, I'd suggestcodeload.github.com
.tar.gz
archives are also available in the same location (e.g. https://codeload.github.com/mviereck/x11docker/tar.gz/master or https://codeload.github.com/mviereck/x11docker/tar.gz/v5.3.3). Sincetar
is more common thanunzip
in GNU/Linux environments, I suggest supporting it. Furthermore, I'd trytar
by default and fall back tozip
if not found.