search

mviereck / x11docker

Run GUI applications and desktops in docker and podman containers. Focus on security.
MIT License
5.62k stars 378 forks source link

Password and shadow #449

Closed marco3181 closed 2 years ago

marco3181 commented 2 years ago

The password option is great but seems not to work. It seems there are some changes needed in the x11docker script. And for security reason, I think SHA512 and a random salt in the shadow would be better. I made changes in my fork and tested on oracle linux with the cinnamon container. I can make a pull request. Thank you for your great work.

mviereck commented 2 years ago

Thank you for the report and the offer of a pull request! I can confirm that a custom password fails in x11docker/cinnamon at least with the screen locker, yet checked. A pull request is appreciated!

marco3181 commented 2 years ago

For the screen locker, I didn't find it yet. I don't know if it is PAM related.

marco3181 commented 2 years ago

For the Cinnamon screen locker, I found this working https://forums.linuxmint.com/viewtopic.php?t=232242 , the last post. There is a problem with files not owned by the group shadow.

mviereck commented 2 years ago

Thank you for the hint with root:shadow for /etc/shadow . x11docker sets the group accordingly now. Now cinnamon screenlocker works at least if running along with --cap-default.