mviereck / x11docker

Run GUI applications and desktops in docker and podman containers. Focus on security.
MIT License
5.62k stars 378 forks source link

--rm added twice #451

Closed a1346054 closed 2 years ago

a1346054 commented 2 years ago

When I run command:

x11docker -it --xc=no --debug alpine:latest

Part of the output is:

DEBUGNOTE[13:32:14,687]: podman command (rootless yes):
  /usr/bin/podman run \
  --rm \
  --pull never \
  --rm \
  --interactive \
  --tty \
  --name x11docker_X142_alpine-latest_23131369578 \
  --user 1000:1000 \
  --userns=keep-id \
  --group-add 1000 \
  --runtime='crun' \
  --network none \
  --cap-drop ALL \
  --cap-add CHOWN \
  --security-opt no-new-privileges \
  --security-opt label=type:container_runtime_t \
  --mount type=bind,source='/usr/bin/catatonit',target='/usr/local/bin/init',readonly \
  --tmpfs /run:exec \
  --tmpfs /run/lock \
  --tmpfs /tmp \
  --mount type=bind,source='/home/user/.cache/x11docker/23131369578-alpine-latest/share',target='/x11docker' \
  --workdir '/tmp' \
  --entrypoint env \
  --env 'container=podman' \
  --env 'WAYLAND_DISPLAY=' \
  --env 'USER=user' \
  -- alpine:latest /usr/local/bin/init -- /bin/sh - /x11docker/containerrc

Notice that --rm is added twice to the generated podman run command. It doesn't break anything right now, it's a purely cosmetic issue, however still odd that it happens.

mviereck commented 2 years ago

Indeed, thank your for pointing me on this! I've removed one --rm in the latest commit.