search

mvillis / measure-mate

Simple tool to track maturity assessments
MIT License
13 stars 4 forks source link

try using browser history, not hash history #148

Closed rloomans closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 81a7a380eedbdec6a406829f9907c3350eb075d3 on use-browser-history into 9bf572c56abe92c85a81314fc9f0dcb65e735709 on master.

mvillis commented 8 years ago

looks like it's just IE8/9 we lose when switching to browser history: http://caniuse.com/#feat=history

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ff01af520fce7ba5770a96b3c4289e1c4a552b6c on use-browser-history into 9bf572c56abe92c85a81314fc9f0dcb65e735709 on master.

rloomans commented 8 years ago

Yeah... and even for them, it's mentioned in the react-router documentation that the fallback is full page reloads. Not ideal but it'll still "work".

On 31 March 2016 at 23:15, Mike Villis notifications@github.com wrote:

looks like it's just IE8/9 we lose when switching to browser history: http://caniuse.com/#feat=history

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/mvillis/measure-mate/pull/148#issuecomment-203931907

Robert Loomans robert@loomans.org