search

mvisonneau / helm-charts

Personal Helm charts repository
Apache License 2.0
67 stars 58 forks source link

Enable dnspolicy in tailscale-relay #42

Closed steve-winter closed 2 years ago

steve-winter commented 2 years ago

Summary

Please can the dnspolicy configuration parameter be added to the tailscale-relay.

Justification

The existing configuration enables setting the hostNetwork but cannot configure the dnspolicy. Per documentation the dnspolicy must be explicitly set. At present, in my use case at least, pod fails to start with hostnetwork set, without configuring dnspolicy manually.

For Pods running with hostNetwork, you should explicitly set its DNS policy "ClusterFirstWithHostNet".

Solution

Amend statefulset.yaml to include dnspolicy alongside the hostnetwork configuration. Possibly also valuable to default the dnspolicy to ClusterFirstWithHostNet when hostnetwork is true.

I am happy to create a Pull request, but looking to confirm your agreement before proceeding. And I appreciate the work in the repository to date.

mvisonneau commented 2 years ago

hey @steve-winter, sounds good, I implemented it as part of the latest release!