search

mvisonneau / helm-charts

Personal Helm charts repository
Apache License 2.0
67 stars 58 forks source link

(gitlab-ci-pipelines-exporter) feat: adds ingressClassName property #49

Closed cebidhem closed 2 years ago

cebidhem commented 2 years ago

Fixes https://github.com/mvisonneau/helm-charts/issues/48

This will allow the users to either use the ingress property ingressClassName, or to keep using the deprecated annotation. It is default to empty so that it does not change the behavior of the chart.

README has been updated, and fix version has been bumped. If you'd prefer to see the minor version bumped, just let me know and I'll update the PR.

Hope this gets merged and release soon!

Let me know if there's anything I could add.

Signed-off-by: cebidhem cebidhem@pm.me

mvisonneau commented 2 years ago

brilliant, thanks a lot @cebidhem 🙇 !