search

mvisonneau / helm-charts

Personal Helm charts repository
Apache License 2.0
67 stars 58 forks source link

[gitlab-ci-pipelines-exporter] install/upgrade failed because label longer than 63 characters #60

Closed bt909 closed 1 year ago

bt909 commented 1 year ago

Hello,

the label helm.sh/from can be longer than 63 characters. It is build by app.fullname which is truncated to 63 characters, but then a "deploy." is put in front of it, which just exceeds the 63 character limit.

Is it okay to just remove this label, as it is not needed?

e.g: https://github.com/mvisonneau/helm-charts/blob/main/charts/gitlab-ci-pipelines-exporter/templates/deployment.yaml#L23

mvisonneau commented 1 year ago

thanks for raising this and providing a fix @bt909. Lets reopen if necessary!