mvisonneau / helm-charts

Personal Helm charts repository
Apache License 2.0
65 stars 58 forks source link

[gitlab-ci-pipeline-exporter] image.pullSecrets is not transfered to deployment #69

Open Hurricaane opened 1 year ago

Hurricaane commented 1 year ago

In the file deployment.yml of the gitlab-ci-pipeline-exporter helm chart, on line 36-38 we have :

https://github.com/mvisonneau/helm-charts/blob/fb4d2e5819d4acdf7e1e768ef9f794926107d2e4/charts/gitlab-ci-pipelines-exporter/templates/deployment.yaml#L36-L38

Where we should have :

{{- with .Values.image.pullSecrets }}
imagePullSecrets: {{ toYaml . | nindent 8 }}
{{- end }}