mvladk / sipml5

Automatically exported from code.google.com/p/sipml5
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

dtmf formatted incorrectly #206

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
a) Before posting your issue you MUST answer to the questions otherwise it
will be rejected (invalid status) by us
b) Please check the issue tacker to avoid duplication
c) Please provide network capture (Wireshark) or Javascript console log
if you want quick response

What steps will reproduce the problem?
1. From the latest sipml5 demo, make a call to an asterisk server with a call 
plan that requires dtmf input.
2. Open the keypad and press any numbers.
3. None of them are detected on the asterisk server.  Additionally you are 
presented with errors for malformed dtmf notifications in into messages (errors 
vary depending on use of chan_sip or pjsip). 

What is the expected output? What do you see instead?
I would expect asterisk to be able to interpret the info message delivering the 
dtmf press, but it cannot because they are formatted incorrectly.

What version of the product are you using? On what operating system?
sipml5 live demo (svn commit 222 at the time)
asterisk 13.0.2

Please provide any additional information below.
I've pulled wireshark dumps from the asterisk server while pressing buttons on 
the keypad.  I can see the packet coming in.  While there is no IETF standard 
for dtmf in info messages, there is a draft that outlines the standard 
convention that I can confirm is followed at least by asterisk, freeswitch, and 
cisco.  I haven't investigated others.

https://tools.ietf.org/html/draft-kaplan-dispatch-info-dtmf-package-00#ref-info-
packages

I went ahead and downloaded the latest version of sipml5, updated dtmf-relay to 
dtmf in release/SIPml-api.js and tested.  DTMF worked without an issue with 
this update.

The attached patch from the sipml5/src/tinySIP/src/api appears to fix the issue.

Original issue reported on code.google.com by kevin.co...@simplisafe.com on 21 Jan 2015 at 8:34

Attachments:

GoogleCodeExporter commented 9 years ago
I'm not sure how I missed it, but I just reran my search and found this is a 
duplicate of 204.  Still, this has reference to the relevant rfc as well as a 
patch.

Sorry for the dup.

Original comment by kevin.co...@simplisafe.com on 21 Jan 2015 at 8:36

GoogleCodeExporter commented 9 years ago
Hi,
I am using FreeSWITCH and I have the same problem with dtmf format.
Now I made the corrections in the patch. DTMF works except for # and * keys. 
They are sent as dtmf('0'). Is this a new bug in js?

Original comment by bedhiafi...@gmail.com on 28 Feb 2015 at 12:48

GoogleCodeExporter commented 9 years ago
https://code.google.com/p/sipml5/source/detail?r=228

Original comment by boss...@yahoo.fr on 18 Mar 2015 at 8:41