search

mvllow / modes.nvim

Prismatic line decorations for the adventurous vim user
567 stars 14 forks source link

remove CursorLineNr highlight group #17

Closed shaeinst closed 2 years ago

shaeinst commented 2 years ago

don't need to set CursorLineNr highlight because everyone has their own color set to CursorLineNr group. for example, modes.nvim changes foreground color of Cursor Line Number to any of #f5c359, #c75c6a, #78ccc5, #9745be but what if my color scheme has defined background color of CursorLineNr to any of that 4 colors? my Cursor Line Number would be totally invisible. so, it's batter to no change CursorLineNr .

related to https://github.com/mvllow/modes.nvim/issues/13

mvllow commented 2 years ago

The same argument could be made for the cursorline etc. This plugin was made to style elements. I would, however, consider adding an option to disable certain aspects similar to https://github.com/mvllow/modes.nvim/commit/57fb7a86c0f893bb201c2aa5db3f6950c3c9c3ea

shaeinst commented 2 years ago

well, yes

The same argument could be made for the cursorline etc.

instead of hard coding color, it would make more sense to have option to set colors.

mvllow commented 2 years ago

there are currently options to override each mode's colour which does modify a few different highlight groups. is there something that wouldn't be solved by adding an option to disable this plugin from modifying line numbers for example?

mvllow commented 2 years ago

After reading this again as well as clarification in the related issue I now understand the problem. I think we will end up only setting the line number foreground if the background has not been set but I'm open to feedback. Let's discuss in the issue the best solution 😌

mvllow commented 2 years ago

Closing in favour of #20. Feel free to try out the next branch:

The default highlights should work better with more themes. But you may disable line number highlighting entirely via set_number = false