mvllow / modes.nvim

Prismatic line decorations for the adventurous vim user
550 stars 13 forks source link

Colorscheme is not always respected #37

Closed mvllow closed 1 year ago

mvllow commented 2 years ago

After #36, Rosé Pine theme (dark variant) doesn't use the colorscheme's palette. Light mode works as expected.

Users can pin to tag = v0.2.0 if using a theme that is affected by this.

fitrh commented 2 years ago

How to reproduce this bug?

mvllow commented 2 years ago

With this config...

use({
    'rose-pine/neovim',
    config = function()
        require('rose-pine').setup()
        vim.cmd('colorscheme rose-pine')
    end,
})
use({
    'mvllow/modes.nvim',
    -- Loading modes after rose-pine is a decent workaround
    -- after = 'rose-pine',
    config = function()
        require('modes').setup()
    end,
})

...Rosé Pine themes modes when the initial background is set to light, e.g. using the dawn variant. When neovim loads with an initial background of dark due to your system theme being in dark mode, Rosé Pine does not completely theme modes.

Manually doing :set background=dark temporarily fixes the issue and properly themes modes.

As mentioned in the code block above, loading modes after the theme fixes this issue, but this workaround wasn't needed before #36. I am unable to pinpoint what exactly caused this issue, though.

Edited to be more concise

fitrh commented 2 years ago

Hmm, does calling vim.on_key at the very end of setup did not solve this issue?