search

mvmike / min-cal-widget

Minimal calendar widget
BSD 3-Clause "New" or "Revised" License
89 stars 15 forks source link

Screenshots for F-Droid #59

Closed mondlicht-und-sterne closed 3 years ago

mondlicht-und-sterne commented 3 years ago

You can add Screenshots for F-Droid, too, if you want.

https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/

https://gitlab.com/snippets/1895688

mvmike commented 3 years ago

Moved metadata (screenshots, changelog descriptions and icon) to fastlane in ce59955cd035c6abc40545de32bbca21a3efeb8d

Not sure if we need to remove old metadata from fdroiddata

fossdd commented 3 years ago

Yes, fdroiddata has also the description. Great that you created fastlane files for these things.

But could you re-tag your release 1.6.0?

I see you did not much, which will be added to 1.6.0.

I've opened a MR that removes the Description from fdroiddata. So that we're using your fastlane metadata: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/8376

mvmike commented 3 years ago

was planning to release a new version soon with a full migration to kotlin

IzzySoft commented 3 years ago

@mvmike any ETA for that so we can mark it in the corresponding MR?

mvmike commented 3 years ago

migration is taking longer than expected, just released v1.6.1 based on current master codebase

IzzySoft commented 3 years ago

Yeah, things happen… Crossing fingers for easy progress! :crossed_fingers:

So what does that mean for the MR, what note shall we put to keep it easy to follow (and active)?

mvmike commented 3 years ago

Screenshots (and all fastlane info) present in fdroid

IzzySoft commented 3 years ago

@mvmike not all fastlane info – for that we'd need to remove our local stuff, which is easily done. But before doing so: we've got a load of summaries (short_description.txt) for several languages. Would you accept them if we "copied them over" via a PR here, so the work of the translators is not lost?

mvmike commented 3 years ago

Hi @IzzySoft , yes it was me who removed them from fdroiddata in this PR, since the short description has almost no need of being translated.

Maybe in the future we could have fastlane data for all supported languages, but for now i'd say we can get rid of previously existing short descriptions.

Thanks for double checking, though 😃

IzzySoft commented 3 years ago

Ah, I see. Problem is that you didn't remove the Description: from the YAML, so those summaries were obviously recreated as that indicated we have the metadata locally.

Um, funny: that seems to be fixed now; the YAML was updated yesterday here (and a few days earlier in the fdroiddata repo). In this case apologies for the noise – but yes, it could still have been you'd want those summaries and we could have "rescued" them from history, thanks to git :smile: All good then!