search

mvniekerk / tokio-cron-scheduler

Schedule tasks on Tokio using cron-like annotation
Apache License 2.0
529 stars 59 forks source link

Remove unnecessary Sync #13

Closed vkill closed 2 years ago

vkill commented 2 years ago

Hi @mvniekerk

Please ref BoxFuture

Please review it. thank you.

mvniekerk commented 2 years ago

Hi @vkill Thank you for the contribution. If you don't mind, I'm going to hold off on this PR up until 0.6 beta 2 is released and chat with you about it then?

mvniekerk commented 2 years ago

Hi @vkill 0.6 beta 2 has been updated. Can you kindly update your PR please?

vkill commented 2 years ago

Hi @vkill 0.6 beta 2 has been updated. Can you kindly update your PR please?

But I cannot test it now.

   Compiling tokio-cron-scheduler v0.6.0-beta.2 (/path/tokio-cron-scheduler)
error[E0601]: `main` function not found in crate `lib`
   --> examples/lib.rs:1:1
    |
1   | / use std::time::Duration;
2   | | use tokio_cron_scheduler::{Job, JobScheduler};
3   | | use tracing::{error, info};
4   | |
...   |
141 | |     sched.shutdown();
142 | | }
    | |_^ consider adding a `main` function to `examples/lib.rs`
vkill commented 2 years ago

And I have updated based on 0.6 beta 2.

mvniekerk commented 2 years ago

Thank you @vkill