search

mvniekerk / tokio-cron-scheduler

Schedule tasks on Tokio using cron-like annotation
Apache License 2.0
499 stars 61 forks source link

Support using local time instead of utc for cron #49

Closed 4t145 closed 5 months ago

4t145 commented 1 year ago

add features cron_local to replace Utc with Local in schedule.upcoming(timezone) call see issue:

mvniekerk commented 1 year ago

Hi @4t145 Thank you for the PR I'll have a look

zmlgirl commented 1 year ago

@mvniekerk sorry to bother. Is this pr ok or not? I have same issue with timezone right now.

dertin commented 1 year ago

Hi @mvniekerk, have you had a chance to review this PR? I'm considering using this library for a future project, and it'll involve working with tasks in different time zones. Your feedback is valuable. Thanks!

Dkwcs commented 1 year ago

@mvniekerk Hi ,eagerly waiting for reviewing and merging this PR But I guess it wouldn't be enough for full local support, because of next_tick of job will be rewritten with Utc value after first tick. Hope, you will add completely support of local time for this

mvniekerk commented 1 year ago

Hi all I'm busy on a branch Timezone, if you don't mind testing it. It allows per-job TZ setting.

mvniekerk commented 8 months ago

Hi all Thank you for the PR, again. So on 0.10.0 I've added a builder API to have the TZ persisted with the other job data, and have it as part of the scheduling.

Please check if this works OK? Or are there other ideas in this PR that I need to incorporate somehow?

mvniekerk commented 5 months ago

Hi @Dkwcs Thanks for the PR. I'm closing this as I haven't received any feedback yet?