libsmbclient: use pkg-config to get the right CFLAGS/LDFLAGS

mvo5 / libsmbclient-go

Go bindings for libsmbclient

MIT License

18 stars 11 forks source link

libsmbclient: use pkg-config to get the right CFLAGS/LDFLAGS #12

Closed mvo5 closed 2 years ago

mvo5 commented 2 years ago

Thanks to Andreas Hasenack.

panlinux commented 2 years ago

Does this override your previous merge, and does samba now have to ship a pkgconfig file with those flags?

mvo5 commented 2 years ago

Does this override your previous merge, and does samba now have to ship a pkgconfig file with those flags?

This is orthogonal to #11 - the pkg-config files of samba do not set these large file options yet AFAIK so #11 is still needed. However if/when upstream samba changes we could drop #11. I mostly did it because it's nicer than the current hardcoded values in the cgo header.