search

mvo5 / synaptic

The synaptic package manager
GNU General Public License v2.0
169 stars 55 forks source link

Migrate from GTK 3 to GTK 4 #104

Open vanillajonathan opened 2 years ago

vanillajonathan commented 2 years ago

Here is the GTK migration guide: https://docs.gtk.org/gtk4/migrating-3to4.html

Commit ac2c1238ece8d7d694e870597c7bf2a0a5cc1fce was the first step!

mvo5 commented 2 years ago

Hey, yeah, I added https://github.com/mvo5/synaptic/commit/ac2c1238ece8d7d694e870597c7bf2a0a5cc1fce for this. I would love to port it eventually but help would be welcome.

albert-tomanek commented 5 days ago

@mvo5 I can help with this. Can you think of any parts of the code right now that are incompatible with Gtk4?

mvo5 commented 4 days ago

@albert-tomanek Thanks, help would be much appreciated. I don't know if there is anything incompatible in the code, it is now build with -DGDK_DISABLE_DEPRECATED and -DGTK_DISABLE_DEPRECATED and that works. Historically the gtk/rgpkgtreeview.cc has seen tricky because it is a custom listview/treeview (for performance reasons). Most of the other pieces are relatively standard gtk. But keep in mind this went all the way from gtk1->gtk2->gtk3 so the code has a lot of history (and unfortunately it shows in some areas!). But I hope this does not scare you away, I would love to get help and start a gtk4 branch!