Possible memory leaks in rgtaskswin.cc and rgslideshow.cc

mvo5 / synaptic

The synaptic package manager

GNU General Public License v2.0

154 stars 55 forks source link

Possible memory leaks in rgtaskswin.cc and rgslideshow.cc #120

Open Aruise opened 8 months ago

Aruise commented 8 months ago

Hi!

I'm learning some new things for me with static analysator and it reacted to synaptic cc files at lines /gtk/rgslideshow.cc:17 and /gtk/rgtaskswin.cc:132.

Possibly rgslideshow is missing a closedir Screenshot_20231130_104024

And rgtaskswin is missing a pclose Screenshot_20231130_103933

mvo5 commented 7 months ago

Thank you! Those are nice catches! I (unfortunately) do not have much time these days to maintain synaptic so if you could sent a PR that would be awesome!

Aruise commented 7 months ago

I don't have time myself to figure out how pull requests here works, so can't really do it. Also, i don't think it's that important, so whenever you will have the time. Just adding closedir (DIR dir) and pclose (FILE f) seems to be sufficient?